linux-kernel - [PATCH v2] MIPS: OCTEON: fix unreachable code in octeon_irq_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210111132725.4513-1-dong.menglong@zte.com.cn>
Date:   Mon, 11 Jan 2021 05:27:25 -0800
From:   menglong8.dong@...il.com
To:     alexander.sverdlin@...ia.com, paulburton@...nel.org
Cc:     tsbogend@...ha.franken.de, gustavo@...eddedor.com,
        dong.menglong@....com.cn, colin.king@...onical.com,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v2] MIPS: OCTEON: fix unreachable code in octeon_irq_init_ciu

From: Menglong Dong <dong.menglong@....com.cn>

The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
can't be true.

Fix this by change the type of 'r' and 'i' from 'unsigned int'
to 'int'. As 'i' won't be negative, this change works.

Fixes: 99fbc70f8547 ("MIPS: Octeon: irq: Alloc desc before configuring IRQ")
Signed-off-by: Menglong Dong <dong.menglong@....com.cn>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
---
v2:
- change 'Fixes' from 64b139f97c01 to 99fbc70f8547
---
 arch/mips/cavium-octeon/octeon-irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c
index bd47e15d02c7..be5d4afcd30f 100644
--- a/arch/mips/cavium-octeon/octeon-irq.c
+++ b/arch/mips/cavium-octeon/octeon-irq.c
@@ -1444,7 +1444,7 @@ static void octeon_irq_setup_secondary_ciu2(void)
 static int __init octeon_irq_init_ciu(
 	struct device_node *ciu_node, struct device_node *parent)
 {
-	unsigned int i, r;
+	int i, r;
 	struct irq_chip *chip;
 	struct irq_chip *chip_edge;
 	struct irq_chip *chip_mbox;
-- 
2.17.1