linux-kernel - Re: [PATCH v2] MIPS: OCTEON: fix unreachable code in octeon_irq_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210113100722.GA10351@alpha.franken.de>
Date:   Wed, 13 Jan 2021 11:07:22 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     menglong8.dong@...il.com
Cc:     alexander.sverdlin@...ia.com, paulburton@...nel.org,
        gustavo@...eddedor.com, dong.menglong@....com.cn,
        colin.king@...onical.com, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] MIPS: OCTEON: fix unreachable code in
 octeon_irq_init_ciu

On Mon, Jan 11, 2021 at 05:27:25AM -0800, menglong8.dong@...il.com wrote:
> From: Menglong Dong <dong.menglong@....com.cn>
> 
> The type of 'r' in octeon_irq_init_ciu is 'unsigned int', so 'r < 0'
> can't be true.
> 
> Fix this by change the type of 'r' and 'i' from 'unsigned int'
> to 'int'. As 'i' won't be negative, this change works.
> 
> Fixes: 99fbc70f8547 ("MIPS: Octeon: irq: Alloc desc before configuring IRQ")
> Signed-off-by: Menglong Dong <dong.menglong@....com.cn>
> Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> ---
> v2:
> - change 'Fixes' from 64b139f97c01 to 99fbc70f8547
> ---
>  arch/mips/cavium-octeon/octeon-irq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-fixes.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]