lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 12 Jan 2021 14:15:25 +0300 From: Sergei Shtylyov <sergei.shtylyov@...il.com> To: menglong8.dong@...il.com, axboe@...nel.dk Cc: linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org, Menglong Dong <dong.menglong@....com.cn> Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe Hello! On 1/12/21 5:36 AM, menglong8.dong@...il.com wrote: > From: Menglong Dong <dong.menglong@....com.cn> > > Coccinelle reports a redundant error print in rb532_pata_driver_probe. > As 'platform_get_irq' already prints the error message, error print > here is redundant and can be removed. > > Signed-off-by: Menglong Dong <dong.menglong@....com.cn> > --- > drivers/ata/pata_rb532_cf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c > index 479c4b29b856..dcde84f571c4 100644 > --- a/drivers/ata/pata_rb532_cf.c > +++ b/drivers/ata/pata_rb532_cf.c > @@ -115,10 +115,8 @@ static int rb532_pata_driver_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq <= 0) { > - dev_err(&pdev->dev, "no IRQ resource found\n"); > + if (irq <= 0) > return -ENOENT; This still beaks the probe deferral. :-( But that's another problem... [...] MBR, Sergei
Powered by blists - more mailing lists