linux-kernel - Re: [PATCH] ata: remove redundant error print in rb532_pata_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3bzFPeCXzkO1iFy+Sx7GhwRGo=VkOUzrDE4KMCjMx0v-w@mail.gmail.com>
Date:   Wed, 13 Jan 2021 22:04:57 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>, axboe@...nel.dk
Cc:     linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Menglong Dong <dong.menglong@....com.cn>
Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

Hello, Sergei

On Tue, Jan 12, 2021 at 7:15 PM Sergei Shtylyov
<sergei.shtylyov@...il.com> wrote:
>
> Hello!
>
> On 1/12/21 5:36 AM, menglong8.dong@...il.com wrote:
>
[....]
> >       irq = platform_get_irq(pdev, 0);
> > -     if (irq <= 0) {
> > -             dev_err(&pdev->dev, "no IRQ resource found\n");
> > +     if (irq <= 0)
> >               return -ENOENT;
>
>    This still beaks the probe deferral. :-(
>    But that's another problem...
>
> [...]
>
> MBR, Sergei

What does this 'MBR' mean? I am a novice~~~
So, is it better to replace 'platform_get_irq' with
'platform_get_irq_optional' here?

--
 Best Regards
 Menglong Dong