linux-kernel - Re: [PATCH] ata: remove redundant error print in rb532_pata_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b6dcfbf-d534-4a2a-53e0-c942a9120a0f@gmail.com>
Date:   Thu, 14 Jan 2021 11:29:57 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...il.com>
To:     Menglong Dong <menglong8.dong@...il.com>, axboe@...nel.dk
Cc:     linux-ide@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Menglong Dong <dong.menglong@....com.cn>
Subject: Re: [PATCH] ata: remove redundant error print in
 rb532_pata_driver_probe

Hello!

On 13.01.2021 17:04, Menglong Dong wrote:

[...]
>>>        irq = platform_get_irq(pdev, 0);
>>> -     if (irq <= 0) {
>>> -             dev_err(&pdev->dev, "no IRQ resource found\n");
>>> +     if (irq <= 0)
>>>                return -ENOENT;
>>
>>     This still beaks the probe deferral. :-(
>>     But that's another problem...
>>
>> [...]
>>
>> MBR, Sergei
> 
> What does this 'MBR' mean? I am a novice~~~

    Generally speaking, Master Boot Record. But I also use it to send you My 
Best Regards. :-)

> So, is it better to replace 'platform_get_irq' with
> 'platform_get_irq_optional' here?

    No. You should stop overriding the result to -ENOENT and pass the result
up the call chain instead. In order to do it, you should only check for (irq < 0).

> --
>   Best Regards
>   Menglong Dong

MBR, Sergei