linux-kernel - Re: [PATCH] ata: remove redundant error print in rb532_pata_driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADxym3Z088OCMpFvUMG8Ggx3yQXVL0N9=yJ4+CUgxgnTwkEysw@mail.gmail.com>
Date:   Thu, 14 Jan 2021 22:53:46 +0800
From:   Menglong Dong <menglong8.dong@...il.com>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>
Cc:     axboe@...nel.dk, linux-ide@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        Menglong Dong <dong.menglong@....com.cn>
Subject: Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

On Thu, Jan 14, 2021 at 4:30 PM Sergei Shtylyov
<sergei.shtylyov@...il.com> wrote:
[...]
> >
> > What does this 'MBR' mean? I am a novice~~~
>
>     Generally speaking, Master Boot Record. But I also use it to send you My
> Best Regards. :-)

Haha~,

> > So, is it better to replace 'platform_get_irq' with
> > 'platform_get_irq_optional' here?
>
>     No. You should stop overriding the result to -ENOENT and pass the result
> up the call chain instead. In order to do it, you should only check for (irq < 0).

Well, I didn't even notice this. It does seem to be another problem...

---
 Best Regards
 Menglong Dong