linux-kernel - Re: [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37f9fb2c-56bb-b593-ae55-db8fce8304f9@gmail.com>
Date:   Wed, 13 Jan 2021 22:41:06 +0530
From:   Aditya <yashsri421@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>,
        linux-wireless@...r.kernel.org
Cc:     pkshih@...ltek.com, kvalo@...eaurora.org, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        linux-kernel-mentees@...ts.linuxfoundation.org,
        lukas.bulwahn@...il.com
Subject: Re: [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in
 expressions

On 9/1/21 1:11 am, Larry Finger wrote:
> On 1/8/21 9:32 AM, Aditya Srivastava wrote:
>> There are certain conditional expressions in rtlwifi, where a boolean
>> variable is compared with true/false, in forms such as (foo == true) or
>> (false != bar), which does not comply with checkpatch.pl (CHECK:
>> BOOL_COMPARISON), according to which boolean variables should be
>> themselves used in the condition, rather than comparing with true/false
>>
>> E.g., in drivers/net/wireless/realtek/rtlwifi/ps.c,
>> "if (find_p2p_ie == true)" can be replaced with "if (find_p2p_ie)"
>>
>> Replace all such expressions with the bool variables appropriately
>>
>> Signed-off-by: Aditya Srivastava<yashsri421@...il.com>
>> ---
>> - The changes made are compile tested
>> - Applies perfecly on next-20210108
>>
>>   drivers/net/wireless/realtek/rtlwifi/ps.c                 | 4 ++--
>>   drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c       | 8
>> ++++----
>>   drivers/net/wireless/realtek/rtlwifi/rtl8188ee/hw.c       | 4 ++--
>>   drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 4 ++--
>>   drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c       | 4 ++--
>>   drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c      | 8
>> ++++----
>>   6 files changed, 16 insertions(+), 16 deletions(-)
> 
> As has been stated several times, this form of the subject is
> incorrect. It should be: "rtlwifi: <driver_name>: <subject>
> 
> I would prefer that there be separate patches for each driver, not
> that the changes be lumped into a single patch as was done here. Such
> organization makes it a lot easier to find the patches for a given
> driver in case something goes wrong.Note: The driver for ps is
> rtl_pci, and that for rtl8192c is rtl8192c-common. The other driver
> names match their directory.
> 
> Larry
> 

Hi Larry!
I sent the modified patches as patch series separately.
I probably missed CCing you :/

The patch series can be found at:
https://lore.kernel.org/linux-wireless/20210110121525.2407-1-yashsri421@gmail.com/#t

Please review :)

Thanks
Aditya