linux-kernel - Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e3a5c13-db5c-7399-2b80-f1284786ea77@intel.com>
Date:   Wed, 13 Jan 2021 09:11:17 -0800
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Bhaskar Chowdhury <unixbhaskar@...il.com>, fenghua.yu@...el.com,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, x86@...nel.org,
        hpa@...or.com, linux-kernel@...r.kernel.org, gustavo@...eddedor.com
Cc:     rdunlap@...radead.org
Subject: Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away
 and append a colon to match below struct member

Hi Bhaskar,

The prefix in the subject line should be "x86/resctrl:" only. The 
subject line could be (also taking liberty to shorten it here):
x86/resctrl: Fix typo and append a colon to match struct member

I would like to repeat my suggestion made in response to your previous 
version, especially if you are planning cleanup in many areas of the 
kernel: Use "git log" to take a look at the custom of patches in the 
area you are contributing to. While the kernel may appear to be a single 
code base there can be different customs in the various subsystems.

On 1/12/2021 6:03 PM, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
> s/@..._data_kn/@..._data_kn:/
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@...il.com>
> ---
> Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
>   arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..ef9e2c0809b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -142,7 +142,7 @@ enum rdtgrp_mode {
> 
>   /**
>    * struct mongroup - store mon group's data in resctrl fs.
> - * @mon_data_kn		kernlfs node for the mon_data directory
> + * @mon_data_kn:		kernfs node for the mon_data directory
>    * @parent:			parent rdtgrp
>    * @crdtgrp_list:		child rdtgroup node list
>    * @rmid:			rmid for this rdtgroup
> --
> 2.20.1
> 

Reinette