linux-kernel - Re: [PATCH] fs/proc: Expose RSEQ configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210113212547.GA487841@localhost.localdomain>
Date:   Thu, 14 Jan 2021 00:25:47 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Piotr Figiel <figiel@...gle.com>
Cc:     "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Kees Cook <keescook@...omium.org>,
        Alexey Gladkov <gladkov.alexey@...il.com>,
        Christian Brauner <christian.brauner@...ntu.com>,
        Michel Lespinasse <walken@...gle.com>,
        Bernd Edlinger <bernd.edlinger@...mail.de>,
        Andrei Vagin <avagin@...il.com>,
        mathieu.desnoyers@...icios.com, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, posk@...gle.com,
        kyurtsever@...gle.com, ckennelly@...gle.com, pjt@...gle.com
Subject: Re: [PATCH] fs/proc: Expose RSEQ configuration

On Wed, Jan 13, 2021 at 06:41:27PM +0100, Piotr Figiel wrote:
> +static int proc_pid_rseq(struct seq_file *m, struct pid_namespace *ns,
> +				struct pid *pid, struct task_struct *task)
> +{
> +	int res = lock_trace(task);
> +
> +	if (res)
> +		return res;
> +	seq_printf(m, "0x%llx 0x%x\n", (uint64_t)task->rseq, task->rseq_sig);

may I suggest

	"%tx", (uintptr_t)	// or %lx

Mandatory 64-bit is too much on 32-bit.

Or even "%tx %08x" ?