linux-kernel - Re: [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6a4e4abd856aa03b6b91b619cddbeb7@codeaurora.org>
Date:   Thu, 14 Jan 2021 12:09:08 +0800
From:   Can Guo <cang@...eaurora.org>
To:     daejun7.park@...sung.com
Cc:     Greg KH <gregkh@...uxfoundation.org>, avri.altman@....com,
        jejb@...ux.ibm.com, martin.petersen@...cle.com,
        asutoshd@...eaurora.org, stanley.chu@...iatek.com,
        bvanassche@....org, huobean@...il.com,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Sung-Jun Park <sungjun07.park@...sung.com>,
        yongmyung lee <ymhungry.lee@...sung.com>,
        Jinyoung CHOI <j-young.choi@...sung.com>,
        Adel Choi <adel.choi@...sung.com>,
        BoRam Shin <boram.shin@...sung.com>,
        SEUNGUK SHIN <seunguk.shin@...sung.com>
Subject: Re: [PATCH v18 3/3] scsi: ufs: Prepare HPB read for cached sub-region

Hi Daejun,

On 2021-01-13 09:36, Daejun Park wrote:
> Hi Can Guo,
> 
>> > +static void
>> > +ufshpb_set_hpb_read_to_upiu(struct ufshpb_lu *hpb, struct ufshcd_lrb
>> > *lrbp,
>> > +				  u32 lpn, u64 ppn,  unsigned int transfer_len)
>> > +{
>> > +	unsigned char *cdb = lrbp->ucd_req_ptr->sc.cdb;
>> > +
>> > +	cdb[0] = UFSHPB_READ;
>> 
>> You are only replacing opcode in cdb[0], but 
>> ufshcd_add_command_trace()
>> is
>> counting on lrbp->cmd->cmnd. This will lead to wrong opcode recorded 
>> by
>> UFS ftrace.
>> 
> You're comment is good point for improving this patch. But there is no
> "case" for HPB read (0xF8) in ufshcd_add_command_trace().
> So I will add codes to support tracing HPB read command in
> ufshcd_add_command_trace() on next patch.
> 

It is not just about ftrace. If HPB READ cmd fails with sense key infos.
When SCSI layer prints the cmd, it still prints the READ(10) CDB, which 
is
misleading.

Thanks,
Can Guo.

> Thanks,
> Daejun