lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jan 2021 12:53:47 +0800 From: Baolin Wang <baolin.wang7@...il.com> To: Yang Li <abaci-bugfix@...ux.alibaba.com> Cc: Orson Zhai <orsonzhai@...il.com>, Linus Walleij <linus.walleij@...aro.org>, Chunyan Zhang <zhang.lyra@...il.com>, linux-gpio@...r.kernel.org, LKML <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2] pinctrl: sprd: Simplify bool comparison On Wed, Jan 13, 2021 at 11:43 AM Yang Li <abaci-bugfix@...ux.alibaba.com> wrote: > > Fix the following coccicheck warning: > ./drivers/pinctrl/sprd/pinctrl-sprd.c:690:8-23: WARNING: Comparison to > bool > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Signed-off-by: Yang Li <abaci-bugfix@...ux.alibaba.com> You should keep other guy's reviewed-by or acked-by tag for the following version if no other big changes. So again Reviewed-by: Baolin Wang <baolin.wang7@...il.com> > --- > Changes in v2: > - make "pinctrl: sprd:" as subject prefix > > drivers/pinctrl/sprd/pinctrl-sprd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c b/drivers/pinctrl/sprd/pinctrl-sprd.c > index 08dc193..dca7a50 100644 > --- a/drivers/pinctrl/sprd/pinctrl-sprd.c > +++ b/drivers/pinctrl/sprd/pinctrl-sprd.c > @@ -687,7 +687,7 @@ static int sprd_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin_id, > shift = INPUT_SCHMITT_SHIFT; > break; > case PIN_CONFIG_BIAS_PULL_UP: > - if (is_sleep_config == true) { > + if (is_sleep_config) { > val |= SLEEP_PULL_UP; > mask = SLEEP_PULL_UP_MASK; > shift = SLEEP_PULL_UP_SHIFT; > -- > 1.8.3.1 > -- Baolin Wang
Powered by blists - more mailing lists