lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jan 2021 16:50:02 -0800 From: Brendan Higgins <brendanhiggins@...gle.com> To: Daniel Latypov <dlatypov@...gle.com> Cc: David Gow <davidgow@...gle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH v4 3/3] kunit: tool: move kunitconfig parsing into __init__, make it optional On Thu, Jan 14, 2021 at 4:39 PM Daniel Latypov <dlatypov@...gle.com> wrote: > > LinuxSourceTree will unceremoniously crash if the user doesn't call > read_kunitconfig() first in a number of functions. > > And currently every place we create an instance, the caller also calls > create_kunitconfig() and read_kunitconfig(). > Move these instead into __init__() so they can't be forgotten and to > reduce copy-paste. > > The https://github.com/google/pytype type-checker complained that > _config wasn't initialized. With this, kunit_tool now type checks > under both pytype and mypy. > > Add an optional boolean that can be used to disable this for use cases > in the future where we might not need/want to load the config. > > Signed-off-by: Daniel Latypov <dlatypov@...gle.com> > Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com> Tested-by: Brendan Higgins <brendanhiggins@...gle.com>
Powered by blists - more mailing lists