lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 14 Jan 2021 16:50:58 -0800
From:   Brendan Higgins <>
To:     Daniel Latypov <>
Cc:     David Gow <>,
        Linux Kernel Mailing List <>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        Shuah Khan <>
Subject: Re: [PATCH v4 2/3] kunit: tool: fix minor typing issue with None status

On Thu, Jan 14, 2021 at 4:39 PM Daniel Latypov <> wrote:
> The code to handle aggregating statuses didn't check that the status
> actually got set to some non-None value.
> Default the value to SUCCESS instead of adding a bunch of `is None`
> checks.
> This sorta follows the precedent in commit 3fc48259d525 ("kunit: Don't
> fail test suites if one of them is empty").
> Also slightly simplify the code and add type annotations.
> Signed-off-by: Daniel Latypov <>
> Reviewed-by: David Gow <>

Reviewed-by: Brendan Higgins <>
Tested-by: Brendan Higgins <>

Powered by blists - more mailing lists