lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jan 2021 16:50:58 -0800 From: Brendan Higgins <brendanhiggins@...gle.com> To: Daniel Latypov <dlatypov@...gle.com> Cc: David Gow <davidgow@...gle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH v4 2/3] kunit: tool: fix minor typing issue with None status On Thu, Jan 14, 2021 at 4:39 PM Daniel Latypov <dlatypov@...gle.com> wrote: > > The code to handle aggregating statuses didn't check that the status > actually got set to some non-None value. > Default the value to SUCCESS instead of adding a bunch of `is None` > checks. > > This sorta follows the precedent in commit 3fc48259d525 ("kunit: Don't > fail test suites if one of them is empty"). > > Also slightly simplify the code and add type annotations. > > Signed-off-by: Daniel Latypov <dlatypov@...gle.com> > Reviewed-by: David Gow <davidgow@...gle.com> Reviewed-by: Brendan Higgins <brendanhiggins@...gle.com> Tested-by: Brendan Higgins <brendanhiggins@...gle.com>
Powered by blists - more mailing lists