lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 14 Jan 2021 16:51:44 -0800 From: Brendan Higgins <brendanhiggins@...gle.com> To: Daniel Latypov <dlatypov@...gle.com> Cc: David Gow <davidgow@...gle.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH v4 1/3] kunit: tool: surface and address more typing issues On Thu, Jan 14, 2021 at 4:39 PM Daniel Latypov <dlatypov@...gle.com> wrote: > > The authors of this tool were more familiar with a different > type-checker, https://github.com/google/pytype. > > That's open source, but mypy seems more prevalent (and runs faster). > And unlike pytype, mypy doesn't try to infer types so it doesn't check > unanotated functions. > > So annotate ~all functions in kunit tool to increase type-checking > coverage. > Note: per https://www.python.org/dev/peps/pep-0484/, `__init__()` should > be annotated as `-> None`. > > Doing so makes mypy discover a number of new violations. > Exclude main() since we reuse `request` for the different types of > requests, which mypy isn't happy about. > > This commit fixes all but one error, where `TestSuite.status` might be > None. > > Signed-off-by: Daniel Latypov <dlatypov@...gle.com> > Reviewed-by: David Gow <davidgow@...gle.com> Tested-by: Brendan Higgins <brendanhiggins@...gle.com> Acked-by: Brendan Higgins <brendanhiggins@...gle.com>
Powered by blists - more mailing lists