linux-kernel - Re: [PATCH v2] cgroup-v1: add disabled controller check in cgroup1_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAFpt6aYW4nVQoZf@blackbook>
Date:   Fri, 15 Jan 2021 11:08:55 +0100
From:   Michal Koutný <mkoutny@...e.com>
To:     chenzhou <chenzhou10@...wei.com>
Cc:     tj@...nel.org, lizefan.x@...edance.com, hannes@...xchg.org,
        cgroups@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] cgroup-v1: add disabled controller check in
 cgroup1_parse_param()

On Fri, Jan 15, 2021 at 09:55:43AM +0800, chenzhou <chenzhou10@...wei.com> wrote:
> Yeah, this will select all enabled controllers, but which doesn't the behavior we want.
I see what the issue is now.

> See above. Just the mount behavior isn't what we what.
I agree this a bug and your I find your approach correct

Reviewed-by: Michal Koutný <mkoutny@...e.com>

> The behavior was changed since commit f5dfb5315d34 ("cgroup: take
> options parsing into ->parse_monolithic()"), will add this as Fixes.
Thanks.

Michal

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)