linux-kernel - Re: [PATCH] power: supply: ds2780: Switch to using the new API kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210116113746.e7gtlmblvsolygc2@earth.universe>
Date:   Sat, 16 Jan 2021 12:37:46 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Tian Tao <tiantao6@...ilicon.com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: ds2780: Switch to using the new API
 kobj_to_dev()

Hi,

On Tue, Dec 15, 2020 at 09:00:24AM +0800, Tian Tao wrote:
> fixed the following coccicheck:
> drivers/power/supply/ds2780_battery.c:627:60-61: WARNING opportunity for
> kobj_to_dev()
> drivers/power/supply/ds2780_battery.c:672:60-61: WARNING opportunity for
> kobj_to_dev()
> drivers/power/supply/ds2780_battery.c:640:60-61: WARNING opportunity for
> kobj_to_dev()
> drivers/power/supply/ds2780_battery.c:685:60-61: WARNING opportunity for
> kobj_to_dev()
> 
> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/ds2780_battery.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/power/supply/ds2780_battery.c b/drivers/power/supply/ds2780_battery.c
> index dd57a47..2b8c90d 100644
> --- a/drivers/power/supply/ds2780_battery.c
> +++ b/drivers/power/supply/ds2780_battery.c
> @@ -624,7 +624,7 @@ static ssize_t ds2780_read_param_eeprom_bin(struct file *filp,
>  				struct bin_attribute *bin_attr,
>  				char *buf, loff_t off, size_t count)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct power_supply *psy = to_power_supply(dev);
>  	struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
>  
> @@ -637,7 +637,7 @@ static ssize_t ds2780_write_param_eeprom_bin(struct file *filp,
>  				struct bin_attribute *bin_attr,
>  				char *buf, loff_t off, size_t count)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct power_supply *psy = to_power_supply(dev);
>  	struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
>  	int ret;
> @@ -669,7 +669,7 @@ static ssize_t ds2780_read_user_eeprom_bin(struct file *filp,
>  				struct bin_attribute *bin_attr,
>  				char *buf, loff_t off, size_t count)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct power_supply *psy = to_power_supply(dev);
>  	struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
>  
> @@ -682,7 +682,7 @@ static ssize_t ds2780_write_user_eeprom_bin(struct file *filp,
>  				struct bin_attribute *bin_attr,
>  				char *buf, loff_t off, size_t count)
>  {
> -	struct device *dev = container_of(kobj, struct device, kobj);
> +	struct device *dev = kobj_to_dev(kobj);
>  	struct power_supply *psy = to_power_supply(dev);
>  	struct ds2780_device_info *dev_info = to_ds2780_device_info(psy);
>  	int ret;
> -- 
> 2.7.4
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)