linux-kernel - Re: Re: [PATCH] block: Fix an error handling in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <767024ca.436d9.1770adf5c69.Coremail.dinghao.liu@zju.edu.cn>
Date:   Sat, 16 Jan 2021 19:05:46 +0800 (GMT+08:00)
From:   dinghao.liu@....edu.cn
To:     "Chaitanya Kulkarni" <Chaitanya.Kulkarni@....com>
Cc:     "kjlu@....edu" <kjlu@....edu>, "Jens Axboe" <axboe@...nel.dk>,
        "Hannes Reinecke" <hare@...e.de>, "Jan Kara" <jack@...e.cz>,
        "Johannes Thumshirn" <Johannes.Thumshirn@....com>,
        "Ming Lei" <ming.lei@...hat.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH] block: Fix an error handling in add_partition

> On 1/15/21 11:34 PM, Dinghao Liu wrote:
> > Once we have called device_initialize(), we should
> > use put_device() to give up the reference on error,
> > just like what we have done on failure of device_add().
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> Please consider having following commit message, since above
> commit message is looking odd from what we have in the tree :-
> 
> 
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
> 

Thanks for this suggestion!
 
> 
> Also have you tested this patch with the with generating appropriate error ?
> 

No, this problem is found through comparing existing source code. 

Regards,
Dinghao