linux-kernel - Re: [PATCH] block: Fix an error handling in add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR04MB4965E41A9C690FA11883469A86A60@BYAPR04MB4965.namprd04.prod.outlook.com>
Date:   Sat, 16 Jan 2021 08:18:04 +0000
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@....com>
To:     Dinghao Liu <dinghao.liu@....edu.cn>, "kjlu@....edu" <kjlu@....edu>
CC:     Jens Axboe <axboe@...nel.dk>, Hannes Reinecke <hare@...e.de>,
        Jan Kara <jack@...e.cz>,
        Johannes Thumshirn <Johannes.Thumshirn@....com>,
        Ming Lei <ming.lei@...hat.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: Fix an error handling in add_partition

On 1/15/21 11:34 PM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should
> use put_device() to give up the reference on error,
> just like what we have done on failure of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
Please consider having following commit message, since above
commit message is looking odd from what we have in the tree :-


Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().


Also have you tested this patch with the with generating appropriate error ?