linux-kernel - Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42e74960-374a-5ae3-bf15-b68a9d1aab10@redhat.com>
Date:   Mon, 18 Jan 2021 08:22:38 -0800
From:   Tom Rix <trix@...hat.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>, tglx@...utronix.de,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, viresh.kumar@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG
 is defined


On 1/18/21 7:15 AM, Daniel Lezcano wrote:
> On 18/01/2021 14:49, trix@...hat.com wrote:
>> From: Tom Rix <trix@...hat.com>
>>
>> When DEBUG is defined this error occurs
>>
>> drivers/clocksource/mxs_timer.c:138:1: error:
>>   expected ‘;’ before ‘}’ token
>>
>> The preceding statement needs a semicolon.
>>
>> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
>> Signed-off-by: Tom Rix <trix@...hat.com>
>> ---
>>  drivers/clocksource/mxs_timer.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
>> index bc96a4cbf26c..55aa6b72d075 100644
>> --- a/drivers/clocksource/mxs_timer.c
>> +++ b/drivers/clocksource/mxs_timer.c
>> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
>>  	timrot_irq_acknowledge();
>>  
>>  #ifdef DEBUG
>> -	pr_info("%s: changing mode to %s\n", __func__, state)
>> +	pr_info("%s: changing mode to %s\n", __func__, state);
>>  #endif /* DEBUG */
> Mind to replace by pr_debug and remove the #ifdef ?
ok.
>
>>  }
>>  
>>
>