linux-kernel - Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG is defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <830aea92-5ae4-6b04-80c5-349a45feabf9@linaro.org>
Date:   Mon, 18 Jan 2021 16:15:02 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     trix@...hat.com, tglx@...utronix.de, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, viresh.kumar@...aro.org
Cc:     linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clocksource: mxs_timer: add missing semicolon when DEBUG
 is defined

On 18/01/2021 14:49, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> When DEBUG is defined this error occurs
> 
> drivers/clocksource/mxs_timer.c:138:1: error:
>   expected ‘;’ before ‘}’ token
> 
> The preceding statement needs a semicolon.
> 
> Fixes: eb8703e2ef7c ("clockevents/drivers/mxs: Migrate to new 'set-state' interface")
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/clocksource/mxs_timer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
> index bc96a4cbf26c..55aa6b72d075 100644
> --- a/drivers/clocksource/mxs_timer.c
> +++ b/drivers/clocksource/mxs_timer.c
> @@ -133,7 +133,7 @@ static void mxs_irq_clear(char *state)
>  	timrot_irq_acknowledge();
>  
>  #ifdef DEBUG
> -	pr_info("%s: changing mode to %s\n", __func__, state)
> +	pr_info("%s: changing mode to %s\n", __func__, state);
>  #endif /* DEBUG */

Mind to replace by pr_debug and remove the #ifdef ?

>  }
>  
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog