linux-kernel - Re: [PATCH 2/2] media: dt-bindings: media: venus: Add sdm660 DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4ffc21f-eec3-2a25-1383-4c43bdb8fa8c@somainline.org>
Date:   Mon, 18 Jan 2021 18:48:55 +0100
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>
To:     Stanimir Varbanov <stanimir.varbanov@...aro.org>,
        Rob Herring <robh@...nel.org>
Cc:     mchehab@...nel.org, phone-devel@...r.kernel.org,
        linux-media@...r.kernel.org, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, marijn.suijten@...ainline.org,
        konrad.dybcio@...ainline.org, devicetree@...r.kernel.org,
        bjorn.andersson@...aro.org, agross@...nel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 2/2] media: dt-bindings: media: venus: Add sdm660 DT
 schema

Il 18/01/21 18:21, Stanimir Varbanov ha scritto:
> 
> 
> On 1/17/21 9:23 PM, AngeloGioacchino Del Regno wrote:
>> Il 17/01/21 16:45, Rob Herring ha scritto:
>>> On Fri, 15 Jan 2021 19:52:52 +0100, AngeloGioacchino Del Regno wrote:
>>>> Add new qcom,sdm660-venus DT binding schema.
>>>>
>>>> Signed-off-by: AngeloGioacchino Del Regno
>>>> <angelogioacchino.delregno@...ainline.org>
>>>> ---
>>>>    .../bindings/media/qcom,sdm660-venus.yaml     | 164 ++++++++++++++++++
>>>>    1 file changed, 164 insertions(+)
>>>>    create mode 100644
>>>> Documentation/devicetree/bindings/media/qcom,sdm660-venus.yaml
>>>>
>>>> base-commit: 012bd807cf654b992cdc4db7eab85c1e95f9d571
>>>> prerequisite-patch-id: 734bdefdb043a8f91a48916246cc9a36fb5966e5
>>>> prerequisite-patch-id: 999517c02973237996492a41ed5bfc2990083932
>>>> prerequisite-patch-id: a48910425fac61948a7a26bec4d40d63e3368569
>>>> prerequisite-patch-id: b1a1a4216eed0d04dd16e6e8e1053dee185d06d8
>>>> prerequisite-patch-id: dff12be2631cc21ef1c3c930fba49d979f5055fe
>>>>
>>>
>>> My bot found errors running 'make dt_binding_check' on your patch:
>>>
>>> yamllint warnings/errors:
>>>
>>> dtschema/dtc warnings/errors:
>>> Documentation/devicetree/bindings/media/qcom,sdm660-venus.example.dts:20:18:
>>> fatal error: dt-bindings/clock/qcom,mmcc-sdm660.h: No such file or
>>> directory
>>>      20 |         #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
>>>         |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>>> compilation terminated.
>>> make[1]: *** [scripts/Makefile.lib:344:
>>> Documentation/devicetree/bindings/media/qcom,sdm660-venus.example.dt.yaml]
>>> Error 1
>>> make[1]: *** Waiting for unfinished jobs....
>>> make: *** [Makefile:1370: dt_binding_check] Error 2
>>>
>>> See https://patchwork.ozlabs.org/patch/1427279
>>>
>>> This check can fail if there are any dependencies. The base for a patch
>>> series is generally the most recent rc1.
>>>
>>> If you already ran 'make dt_binding_check' and didn't see the above
>>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>>> date:
>>>
>>> pip3 install dtschema --upgrade
>>>
>>> Please check and re-submit.
>>>
>>
>> Yes, because this depends on the commits that are mentioned in the tags.
>> Is there any better way to add a dependency on another patch series?
>>
> 
> What is the status of mmcc-sdm660 clk driver? I guess we have to
> postpone this until clock driver is ready for merge?
> 

I have sent it already, the driver is waiting for review...

By the way, this is not the only driver that I've sent that is getting
postponed because of that and I knew that this one would've had the same
destiny, but I thought to send everything "before I forget" pieces here
and there.

Of course I understand that everyone's time is limited, this is not a
rant at all!

Thanks for your review!

>> - Angelo
>