linux-kernel - Re: [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAOTY__DtGc85JNyxWcebof5h3_Os2ugyy1P0jZsOs0Yzj2miw@mail.gmail.com>
Date:   Mon, 18 Jan 2021 23:05:25 +0800
From:   Chun-Kuang Hu <chunkuang.hu@...nel.org>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>
Cc:     Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Kishon Vijay Abraham I <kishon@...com>,
        Chun-Kuang Hu <chunkuang.hu@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Min Guo <min.guo@...iatek.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>, linux-usb@...r.kernel.org
Subject: Re: [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify
 compatible items

Hi, Chunfeng:

Chunfeng Yun <chunfeng.yun@...iatek.com> 於 2021年1月16日 週六 下午5:07寫道：
>
> The compatilbe "mediatek,mt7623-hdmi-tx" is not supported in driver,
> and in fact uses "mediatek,mt2701-hdmi-tx" instead on MT7623, so changes
> the compatible items to make dependence clear.
>
> Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> ---
>  .../devicetree/bindings/phy/mediatek,hdmi-phy.yaml    | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> index 4752517a1446..0d94950b84ca 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,hdmi-phy.yaml
> @@ -21,10 +21,13 @@ properties:
>      pattern: "^hdmi-phy@[0-9a-f]+$"
>
>    compatible:
> -    enum:
> -      - mediatek,mt2701-hdmi-phy
> -      - mediatek,mt7623-hdmi-phy
> -      - mediatek,mt8173-hdmi-phy
> +    oneOf:
> +      - items:
> +          - enum:
> +              - mediatek,mt7623-hdmi-phy
> +          - const: mediatek,mt2701-hdmi-phy
> +      - const: mediatek,mt2701-hdmi-phy
> +      - const: mediatek,mt8173-hdmi-phy
>

I like move 'items' to the bottom.

- const: mediatek,mt2701-hdmi-phy
- const: mediatek,mt8173-hdmi-phy

- items:
  - enum:
      - mediatek,mt7623-hdmi-phy
  - const: mediatek,mt2701-hdmi-phy

Regards,
Chun-Kuang.

>    reg:
>      maxItems: 1
> --
> 2.18.0