lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jan 2021 10:45:42 +0800 From: Chunfeng Yun <chunfeng.yun@...iatek.com> To: Sergei Shtylyov <sergei.shtylyov@...il.com> CC: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh+dt@...nel.org>, "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, Matthias Brugger <matthias.bgg@...il.com>, Kishon Vijay Abraham I <kishon@...com>, Chun-Kuang Hu <chunkuang.hu@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, Min Guo <min.guo@...iatek.com>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-usb@...r.kernel.org> Subject: Re: [PATCH next 11/15] arm64: dts: mediatek: mt7622: harmonize node names and compatibles On Sat, 2021-01-16 at 12:36 +0300, Sergei Shtylyov wrote: > Hello! > > On 16.01.2021 12:06, Chunfeng Yun wrote: > > > This is used to fix dtbs_check warning > > > > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com> > > --- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 +++++---- > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > index 5b9ec032ce8d..4cfa09b0ca3c 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > @@ -740,8 +740,8 @@ > > status = "disabled"; > > }; > > > > - u3phy: usb-phy@...c4000 { > > - compatible = "mediatek,mt7622-u3phy", > > + u3phy: t-phy@...c4000 { > > What is "t-phy"? Perhaps you should have used just "phy" here... At first I use "phy", but it causes dt_binding_check fail: "'#phy-cells' is a required property" Due to we only need add '#phy-cells' for each subnode (usb-phy, pcie-phy or sata-phy), but not for parent one, I change the parent node name as "t-phy" which is a glue layer node, not a real phy. I also prefer to "phy", but seems dt_binding_check can't distinguish this case. Thanks > > > + compatible = "mediatek,mt7622-tphy", > > "mediatek,generic-tphy-v1"; > > reg = <0 0x1a0c4000 0 0x700>; > > #address-cells = <2>; > > @@ -875,8 +875,9 @@ > > status = "disabled"; > > }; > > > > - sata_phy: sata-phy@...43000 { > > - compatible = "mediatek,generic-tphy-v1"; > > + sata_phy: t-phy@...43000 { > > Same here... > > > + compatible = "mediatek,mt7622-tphy", > > + "mediatek,generic-tphy-v1"; > > #address-cells = <2>; > > #size-cells = <2>; > > ranges; > > MBR, Sergei
Powered by blists - more mailing lists