[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210118132716.49d39a16@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Mon, 18 Jan 2021 13:27:16 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Andre Przywara <andre.przywara@....com>
Cc: Maxime Ripard <mripard@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...l.net>,
Icenowy Zheng <icenowy@...c.io>,
Linus Walleij <linus.walleij@...aro.org>,
Rob Herring <robh@...nel.org>,
Clément Péron <peron.clem@...il.com>,
Samuel Holland <samuel@...lland.org>,
Shuosheng Huang <huangshuosheng@...winnertech.com>,
Yangtao Li <tiny.windzz@...il.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-sunxi@...glegroups.com,
Alexandre Torgue <alexandre.torgue@...com>,
"David S . Miller" <davem@...emloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3 12/21] net: stmmac: dwmac-sun8i: Prepare for second
EMAC clock register
On Mon, 18 Jan 2021 02:08:39 +0000 Andre Przywara wrote:
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> index 58e0511badba..00c10ec7b693 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
> @@ -1129,6 +1129,8 @@ static int sun8i_dwmac_probe(struct platform_device *pdev)
> struct stmmac_priv *priv;
> struct net_device *ndev;
> struct regmap *regmap;
> + struct reg_field syscon_field;
> + u32 syscon_idx = 0;
nit: please keep the longest-to-shortest line ordering of variables
Powered by blists - more mailing lists