linux-kernel - Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210118081237.mgcxyob42hv5hdnp@pengutronix.de>
Date:   Mon, 18 Jan 2021 09:12:37 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Bruno Thomsen <bruno.thomsen@...il.com>,
        devicetree@...r.kernel.org,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        linux-kernel@...r.kernel.org, Bruno Thomsen <bth@...strup.com>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>
Subject: Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset

On Mon, Jan 18, 2021 at 02:32:53PM +0800, Shawn Guo wrote:
> On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> > RTC pcf2127 device driver has changed default behaviour of the watchdog
> > feature in v5.11-rc1. Now you need to explicitly enable it with a
> > device tree property, "reset-source", when used in the board design.
> 
> It sound that the existing DTBs are broken by this default behaviour
> change?

I didn't do a representative research, but I expect that there are only
very few machines that have a working watchdog setup using the pcf2127.
All other machines were surprised by commit

	0e735eaae165 ("rtc: pcf2127: add watchdog feature support")

because they suddenly had a non-functional watchdog device. The
alternative would be to "fix" the device trees of all these machines to
restore pre-v5.4-rc1 behaviour. This is IMHO worse.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)