linux-kernel - Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210118063252.GJ28365@dragon>
Date:   Mon, 18 Jan 2021 14:32:53 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Bruno Thomsen <bruno.thomsen@...il.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Bruno Thomsen <bth@...strup.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Rasmus Villemoes <rasmus.villemoes@...vas.dk>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [PATCH] ARM: dts: imx7d-flex-concentrator: fix pcf2127 reset

On Mon, Jan 11, 2021 at 04:15:37PM +0100, Bruno Thomsen wrote:
> RTC pcf2127 device driver has changed default behaviour of the watchdog
> feature in v5.11-rc1. Now you need to explicitly enable it with a
> device tree property, "reset-source", when used in the board design.

It sound that the existing DTBs are broken by this default behaviour
change?

> 
> Fixes: 71ac13457d9d ("rtc: pcf2127: only use watchdog when explicitly available")
> 
> Signed-off-by: Bruno Thomsen <bruno.thomsen@...il.com>
> Cc: Bruno Thomsen <bth@...strup.com>
> Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> Cc: Rasmus Villemoes <rasmus.villemoes@...vas.dk>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>

Applied, thanks.

Shawn

> ---
>  arch/arm/boot/dts/imx7d-flex-concentrator.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-flex-concentrator.dts b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> index 84b095279e65..bd6b5285aa8d 100644
> --- a/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> +++ b/arch/arm/boot/dts/imx7d-flex-concentrator.dts
> @@ -115,6 +115,7 @@ pcf2127: rtc@0 {
>  		compatible = "nxp,pcf2127";
>  		reg = <0>;
>  		spi-max-frequency = <2000000>;
> +		reset-source;
>  	};
>  };
>  
> 
> base-commit: 7c53f6b671f4aba70ff15e1b05148b10d58c2837
> -- 
> 2.29.2
>