linux-kernel - Re: hwmon: (nct6683) Support ASRock boards.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d5630b5e-52ec-4fc7-b8f3-ac219d0bfbbb@www.fastmail.com>
Date:   Tue, 19 Jan 2021 14:15:58 +0900
From:   Blaž Hrastnik <blaz@...n.io>
To:     "Jean Delvare" <jdelvare@...e.com>,
        "Guenter Roeck" <linux@...ck-us.net>,
        "Jonathan Corbet" <corbet@....net>, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Cc:     "David Bartley" <andareed@...il.com>
Subject: Re: hwmon: (nct6683) Support ASRock boards.

(cc-ing David Bartley, who wrote the MSI patch)

I had a follow-up question: I noticed that support for MSI was added in
December, but there's this conditional that wasn't changed:

	/* Only update pwm values for Mitac boards */
	if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
		return attr->mode | S_IWUSR;

Should this continue to only apply for Mitac boards, or should it be changed to
!= NCT6683_CUSTOMER_ID_INTEL?

Blaž