linux-kernel - Re: hwmon: (nct6683) Support ASRock boards.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e57954ca-b2df-bb61-5717-51d63b4cd8d4@roeck-us.net>
Date:   Mon, 18 Jan 2021 21:49:52 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Blaž Hrastnik <blaz@...n.io>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        linux-doc@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>
Cc:     David Bartley <andareed@...il.com>
Subject: Re: hwmon: (nct6683) Support ASRock boards.

On 1/18/21 9:15 PM, Blaž Hrastnik wrote:
> (cc-ing David Bartley, who wrote the MSI patch)
> 
> I had a follow-up question: I noticed that support for MSI was added in
> December, but there's this conditional that wasn't changed:
> 
> 	/* Only update pwm values for Mitac boards */
> 	if (data->customer_id == NCT6683_CUSTOMER_ID_MITAC)
> 		return attr->mode | S_IWUSR;
> 
> Should this continue to only apply for Mitac boards, or should it be changed to
> != NCT6683_CUSTOMER_ID_INTEL?
> 

No, this has to be tested explicitly for each vendor.

Guenter