linux-kernel - Re: [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jan 2021 10:10:42 +0800
From:   Tony W Wang-oc <TonyWWang-oc@...oxin.com>
To:     Isaac Chen <tingyi364@...il.com>
CC:     <linux-kernel@...r.kernel.org>, <CobeChen@...oxin.com>,
        <TimGuo-oc@...oxin.com>, <QiyuanWang@...oxin.com>,
        <HerryYang@...oxin.com>, <CooperYan@...oxin.com>
Subject: Re: [PATCH] x86/cpu/zhaoxin: Fix wrong lowercase naming and indent

On 19/01/2021 01:25, Isaac Chen wrote:
> This is printed during kernel boot, match it with other supported x86 cpus.
>     [    0.000000] KERNEL supported cpus:
>     [    0.000000]   Intel GenuineIntel
>     [    0.000000]   AMD AuthenticAMD
>     [    0.000000]   Hygon HygonGenuine
>     [    0.000000]   Centaur CentaurHauls
>     [    0.000000]   zhaoxin   Shanghai
> 
> Signed-off-by: Isaac Chen <tingyi364@...il.com>
> ---
>  arch/x86/kernel/cpu/zhaoxin.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
> index 05fa4ef63490..f155bbd2aa97 100644
> --- a/arch/x86/kernel/cpu/zhaoxin.c
> +++ b/arch/x86/kernel/cpu/zhaoxin.c
> @@ -120,8 +120,8 @@ zhaoxin_size_cache(struct cpuinfo_x86 *c, unsigned int size)
>  #endif
>  
>  static const struct cpu_dev zhaoxin_cpu_dev = {
> -	.c_vendor	= "zhaoxin",
> -	.c_ident	= { "  Shanghai  " },
> +	.c_vendor	= "Zhaoxin",

Thanks for this patch.

> +	.c_ident	= { "Shanghai" },

The Vendor Identification String from CPUID leaf 0x00000000 of Zhaoxin
CPUs is not "Shanghai", ".c_ident = { "Shanghai" }," will cause the
matching of Zhaoxin CPUs fail.
Please do not modify ".c_ident = { "  Shanghai  " },".

Sincerely,
Tonyw