linux-kernel - Re: [PATCH v2] clk: imx6q: demote warning about pre-boot ldb_di

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOMZO5BdtfXoXMNr0Rsr5YTrahg6Pnz90eryksN4ctnSvOwU+A@mail.gmail.com>
Date:   Mon, 18 Jan 2021 23:10:39 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Ahmad Fatoum <a.fatoum@...gutronix.de>
Cc:     Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Fabio Estevam <fabio.estevam@....com>,
        linux-clk <linux-clk@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] clk: imx6q: demote warning about pre-boot ldb_di_clk reparenting

Hi Ahmad,

On Mon, Jan 18, 2021 at 8:30 AM Ahmad Fatoum <a.fatoum@...gutronix.de> wrote:
>
> Since 5d283b083800 ("clk: imx6: Fix procedure to switch the parent
> of LDB_DI_CLK"), the clock driver warns if ldb_di\d_sel is changed
> from reset value on system boot. This warning is printed even if
> the bootloader (or a previous kernel that did kexec) followed the
> correct procedure for glitch-free reparenting.
>
> As such systems are doing everything correctly, a warning is too
> harsh. Demote to a notice, so users are still alerted, but without
> cluttering a loglevel=5 boot.
>
> While at it, add the words "possible glitch" into the log message, to
> make it more user-friendly.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

Reviewed-by: Fabio Estevam <festevam@...il.com>