linux-kernel - Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f531bec0c48efdeafccd1b251b97ec11@protonic.nl>
Date:   Wed, 20 Jan 2021 15:47:23 +0100
From:   robin <robin@...tonic.nl>
To:     Oleksij Rempel <o.rempel@...gutronix.de>
Cc:     Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, devicetree@...r.kernel.org,
        Fabio Estevam <festevam@...il.com>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        David Jander <david@...tonic.nl>,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v1 4/7] ARM: dts: imx6dl-prtvt7: add TSC2046 touchscreen
 node

On 2021-01-20 15:22, Oleksij Rempel wrote:
> Add touchscreen support to the Protonic VT7 board.
> 
> Co-Developed-by: Robin van der Gracht <robin@...tonic.nl>
> Signed-off-by: Robin van der Gracht <robin@...tonic.nl>
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---
>  arch/arm/boot/dts/imx6dl-prtvt7.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> index d9cb1e41cc10..63ae2065834c 100644
> --- a/arch/arm/boot/dts/imx6dl-prtvt7.dts
> +++ b/arch/arm/boot/dts/imx6dl-prtvt7.dts
> @@ -266,6 +266,26 @@ &ecspi2 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_ecspi2>;
>  	status = "okay";
> +
> +	touchscreen@0 {
> +		compatible = "ti,tsc2046";
> +		reg = <0>;
> +		pinctrl-0 = <&pinctrl_tsc>;
> +		pinctrl-names ="default";
> +		spi-max-frequency = <100000>;
> +		interrupts-extended = <&gpio3 20 IRQ_TYPE_EDGE_FALLING>;
> +		pendown-gpio = <&gpio3 20 GPIO_ACTIVE_LOW>;
> +
> +		touchscreen-inverted-x;
> +		touchscreen-inverted-y;

Please remove both inverted properties since it's not inverted.

> +		touchscreen-max-pressure = <4095>;
> +
> +		ti,vref-delay-usecs = /bits/ 16 <100>;
> +		ti,x-plate-ohms = /bits/ 16 <800>;
> +		ti,y-plate-ohms = /bits/ 16 <300>;
> +
> +		wakeup-source;
> +	};
>  };
> 
>  &i2c1 {

Robin