linux-kernel - Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAhtDKne2/x97YHj@hirez.programming.kicks-ass.net>
Date:   Wed, 20 Jan 2021 18:49:00 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     vincent.donnefort@....com
Cc:     tglx@...utronix.de, linux-kernel@...r.kernel.org,
        valentin.schneider@....com
Subject: Re: [PATCH 3/4] cpu/hotplug: Add cpuhp_invoke_callback_range()

On Mon, Jan 11, 2021 at 05:10:46PM +0000, vincent.donnefort@....com wrote:
> +		if (can_rollback_cpu(st))
> +			WARN_ON(cpuhp_invoke_callback_range(false, cpu, st,
> +							    prev_state));

> +	if (ret)
>  		/*
>  		 * DYING must not fail!
>  		 */
>  		WARN_ON_ONCE(ret);
> -	}

> +	if (ret) {
> +
> +		cpuhp_reset_state(st, prev_state);
> +
> +		if (st->state < prev_state)
> +			WARN_ON(cpuhp_invoke_callback_range(true, cpu, st,
> +							    prev_state));
>  	}

> +	if (ret)
>  		/*
>  		 * STARTING must not fail!
>  		 */
>  		WARN_ON_ONCE(ret);
> -	}

Stuff like that is CodingStyle fail.