linux-kernel - Re: [PATCH/RFC] soc: renesas: rcar-sysc: Mark device node OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdUfA2LgXxz1srbgQLiMw=oadrJ0ASMnwcvCO2xVXqWnUw@mail.gmail.com>
Date:   Thu, 21 Jan 2021 16:38:38 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Saravana Kannan <saravanak@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Marc Zyngier <maz@...nel.org>,
        Kevin Hilman <khilman@...libre.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH/RFC] soc: renesas: rcar-sysc: Mark device node
 OF_POPULATED after init

Hi Saravana,

On Wed, Jan 20, 2021 at 6:09 PM Saravana Kannan <saravanak@...gle.com> wrote:
> On Wed, Jan 20, 2021 at 6:23 AM Geert Uytterhoeven
> <geert+renesas@...der.be> wrote:
> > The R-Car System Controller (SYSC) driver registers PM domains from an
> > early_initcall().  It does not use a platform driver, as secondary CPU
> > startup on R-Car H1 needs to control the CPU power domains, before
> > initialization of the driver framework.
> >
> > As fw_devlink only considers platform devices,
>
> Correction. It only considers devices. As in, devices on all types of
> busses are supported.

OK.

> > it does not know that the
> > System Controller is ready.  Hence probing of on-chip devices that are
> > part of the SYSC PM domain fail:
> >
> >     probe deferral - supplier e6180000.system-controller not ready
> >
> > Fix this by setting the OF_POPULATED flag for the SYSC device node after
> > successful initialization.  This will make of_link_to_phandle() ignore
> > the SYSC device node as a dependency, and consumer devices will be
> > probed again.
>
> It'd still be nice if you could (maybe in a later patch), at least
> probe all the power domains that aren't really needed this early.
> Using the driver core framework (when it's possible), gives you nice
> things :)

Which nice things are you thinking of? Making the driver modular?
At least on R-Car H1, it needs to be built-in for SMP to work.

> +Rob. I know he hates people using OF_POPULATED, but I think this case
> is reasonable and want to make sure he's aware of this.
>
> Once you fix my commit nitpick, you can add:
> Reviewed-by: Saravana Kannan <saravanak@...gle.com>

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds