linux-kernel - Re: restore splice and sendfile support on kernfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5a13228c-6003-2499-a987-23d39f1926cf@phytec.de>
Date:   Thu, 21 Jan 2021 18:41:35 +0100
From:   Robert Karszniewicz <r.karszniewicz@...tec.de>
To:     Christoph Hellwig <hch@....de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Tejun Heo <tj@...nel.org>
CC:     Siddharth Gupta <sidgup@...eaurora.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: restore splice and sendfile support on kernfs

On 1/20/21 9:46 PM, Christoph Hellwig wrote:
> Hi Greg and Tejun,
> 
> this fixes a regression in Linux 5.10 that stopped sendfile and splice
> from working on kernfs/sysfs files.
> 
> Diffstt:
>  file.c |   65 ++++++++++++++++++++++++-----------------------------------------
>  1 file changed, 24 insertions(+), 41 deletions(-)
> 

Tested-by: Robert Karszniewicz <r.karszniewicz@...tec.de>

Confirm that it fixes firmwared for me.

Also, I am 100% sure that the commit that actually breaks firmwared for me is
4d03e3cc5982 ("fs: don't allow kernel reads and writes without iter ops")
which is one commit right before
36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
. I just verified it again.

Thank you,
Robert