linux-kernel - Re: [PATCH v2 0/6] Add Wacom I2C support to rM2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210122161404.thcocfjghfqaga6t@pengutronix.de>
Date:   Fri, 22 Jan 2021 17:14:04 +0100
From:   Marco Felsch <m.felsch@...gutronix.de>
To:     Alistair Francis <alistair@...stair23.me>
Cc:     dmitry.torokhov@...il.com, linux-input@...r.kernel.org,
        linux-imx@....com, kernel@...gutronix.de, alistair23@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/6] Add Wacom I2C support to rM2

Hi Alistair,

thanks for the patches. Before getting into the series please check all
your commit subjects. Also please check that you do only one logical
change per patch: e.g. adding DT-Support means: Add the dt-table and not
more.

I looking forward to your v2 :)

Regards,
  Marco

On 21-01-20 22:56, Alistair Francis wrote:
> Add support to the reMarkable2 (rM2) for the Wacom I2C device.
> 
> This is based on the reMarkable Linux fork and with this series I am
> able to probe the Wacom digitiser.
> 
> Alistair Francis (6):
>   devicetree/bindings: Initial commit of wacom,wacom-i2c
>   input/touchscreen: Add device tree support to wacom_i2c
>   touchscreen/wacom_i2c: Add support for distance and tilt x/y
>   touchscreen/wacom_i2c: Clean up the query device fields
>   touchscreen/wacom_i2c: Add support for vdd regulator
>   arch/arm: reMarkable2: Enable wacom_i2c
> 
>  .../input/touchscreen/wacom,wacom-i2c.yaml    |  48 +++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
>  arch/arm/boot/dts/imx7d-remarkable2.dts       |  41 ++++++
>  arch/arm/configs/imx_v6_v7_defconfig          |   1 +
>  drivers/input/touchscreen/wacom_i2c.c         | 136 +++++++++++++++---
>  5 files changed, 205 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/wacom,wacom-i2c.yaml
> 
> -- 
> 2.29.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |