linux-kernel - Re: [PATCH] pinctrl: sunxi: fix use-after-free in sunxi_pmx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c97264c-8d54-427d-8453-6fd1085c36d3.liu.xiang@zlingsmart.com>
Date:   Fri, 22 Jan 2021 14:15:36 +0800
From:   "liu xiang" <liu.xiang@...ngsmart.com>
To:     "Maxime Ripard" <maxime@...no.tech>
Cc:     "linux-gpio" <linux-gpio@...r.kernel.org>,
        "linus.walleij" <linus.walleij@...aro.org>, "wens" <wens@...e.org>,
        "jernej.skrabec" <jernej.skrabec@...l.net>,
        "linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "liuxiang_1999" <liuxiang_1999@....com>
Subject: Re: [PATCH] pinctrl: sunxi: fix use-after-free in sunxi_pmx_free()

> Hi,

> On Tue, Jan 19, 2021 at 02:29:08PM +0800, Liu Xiang wrote:
> When CONFIG_REGULATOR is not set, sunxi_pmx_request() always return
> success. Even a group of pins call sunxi_pmx_request(), the refcount
> is only 1. This can cause a use-after-free warning in sunxi_pmx_free().
> To solve this problem, go to err path if regulator_get() return NULL
> or error.
> 
> Signed-off-by: Liu Xiang <liu.xiang@...ngsmart.com>

> Is there any drawback to depending on CONFIG_REGULATOR?

> Given that we need those regulators enabled anyway, I guess we could
> just select or depends on it
>
> Maxime


Yes, I think so. But CONFIG_REGULATOR is not enabled by default now.
So I can find this problem during startup.