linux-kernel - Re: [PATCH v3 0/2] Make it possible to reserve memory on 64bit platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAr8xy9t2gYKsjue@smile.fi.intel.com>
Date:   Fri, 22 Jan 2021 18:26:47 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wesley Zhao <zhaowei1102@...ndersoft.com>
Cc:     akpm@...ux-foundation.org, keescook@...omium.org,
        tglx@...utronix.de, kerneldev@...smulder.nl, nivedita@...m.mit.edu,
        joe@...ches.com, gpiccoli@...onical.com, aquini@...hat.com,
        gustavoars@...nel.org, ojeda@...nel.org, ndesaulniers@...ogle.com,
        linux-kernel@...r.kernel.org, david@...hat.com,
        dan.j.williams@...el.com, guohanjun@...wei.com,
        mchehab+huawei@...nel.org
Subject: Re: [PATCH v3 0/2] Make it possible to reserve memory on 64bit
 platform

On Fri, Jan 22, 2021 at 07:55:35AM -0800, Wesley Zhao wrote:
> I was trying to reserve some memory to save logs incase that Android panic or hang and then
> I can read the logs from QNX side from the memory reserved before on the Qualcomm 8155 hypervisor platform,
> and I find the "reserve=" parameter only support 32bit,so I made some change and send these patches.

This part is okay.

> I run the cmdline_kunit.c and got these:
> [    1.663048] 1..1
> [    1.663107]     # Subtest: cmdline
> [    1.663145]     1..3
> [    1.663795]     ok 1 - cmdline_test_noint
> [    1.664139]     ok 2 - cmdline_test_lead_int
> [    1.664553]     ok 3 - cmdline_test_tail_int
> [    1.664788] ok 1 - cmdline

This is not okay, you have to have test cases to be added for your new API.
Besides the fact that you don't need it at all. See my further comments.

> Additionaly:
> 	I test on the qemu with some cmdline like[qemu-system-x86_64 -kernel linux-next/arch/x86_64/boot/bzImage
> 	-hda ubuntu-system.ext4 -append "root=/dev/sda init=/bin/bash console=ttyS0 reserve=0x180000000,0x123456"
> 	-nographic] and check the /proc/iomem with 180000000-180123455 : reserved.
> 	And some other tests with the get_option with the parameter(-12345678) and so on

-- 
With Best Regards,
Andy Shevchenko