linux-kernel - Re: [PATCH v3 2/2] resource: Make it possible to reserve memory on 64bit platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YAr9xaQM3LTU8vfS@smile.fi.intel.com>
Date:   Fri, 22 Jan 2021 18:31:01 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Wesley Zhao <zhaowei1102@...ndersoft.com>
Cc:     akpm@...ux-foundation.org, keescook@...omium.org,
        tglx@...utronix.de, kerneldev@...smulder.nl, nivedita@...m.mit.edu,
        joe@...ches.com, gpiccoli@...onical.com, aquini@...hat.com,
        gustavoars@...nel.org, ojeda@...nel.org, ndesaulniers@...ogle.com,
        linux-kernel@...r.kernel.org, david@...hat.com,
        dan.j.williams@...el.com, guohanjun@...wei.com,
        mchehab+huawei@...nel.org
Subject: Re: [PATCH v3 2/2] resource: Make it possible to reserve memory on
 64bit platform

On Fri, Jan 22, 2021 at 07:55:37AM -0800, Wesley Zhao wrote:
> For now "reserve=" is limitied to 32bit,not available on 64bit
> platform,so we change the get_option() to get_option_ull(added in
> patch: commit 4b6bfe96265e ("lib/cmdline: add new function
> get_option_ull()"))

Do better grammar and punctuation.

"For now "reserve=" is limited to 32bit, and not available on 64bit platform,
so we change the get_option() to get_option_ull() which is added in the
previous patch."

But!

You don't need to alter cmdline.c at all, see memparse() for the details!
And you have been told already, look at other options. You failed to mentioned
in the cover letter what's wrong with recommended memmap= approach.

-- 
With Best Regards,
Andy Shevchenko