linux-kernel - Re: [PATCH] USB: usblp: don't call usb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210124233924.34d278fc@suzdal.zaitcev.lan>
Date:   Sun, 24 Jan 2021 23:39:52 -0600
From:   Pete Zaitcev <zaitcev@...hat.com>
To:     Jeremy Figgins <kernel@...emyfiggins.com>
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, stern@...land.harvard.edu,
        zaitcev@...hat.com
Subject: Re: [PATCH] USB: usblp: don't call usb_set_interface if there's a
 single alt

On Sat, 23 Jan 2021 18:21:36 -0600
Jeremy Figgins <kernel@...emyfiggins.com> wrote:

> Signed-off-by: Jeremy Figgins <kernel@...emyfiggins.com>

> +++ b/drivers/usb/class/usblp.c
> +	if (usblp->intf->num_altsetting > 1) {

Acked-by: Pete Zaitcev <zaitcev@...hat.com>

I am having some misgivings about it, but let's see if it works.
At worst, someone will complain and we'll revert to quirks.

-- Pete