linux-kernel - Re: [PATCH V3] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdadvp9t5xdpK+=35jwfbrR0AXM0bRSWBfWH9jJFBbEyeA@mail.gmail.com>
Date:   Mon, 25 Jan 2021 14:11:23 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Hailong Fan <hailong.fan@...iatek.com>
Cc:     Sean Wang <sean.wang@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        youlin.pei@...iatek.com, Nicolas Boichat <drinkcat@...omium.org>,
        srv_heupstream@...iatek.com, chentsung@...omium.org,
        gtk_pangao@...iatek.com, Hanks Chen <hanks.chen@...iatek.com>,
        yong.wu@...iatek.com
Subject: Re: [PATCH V3] pinctrl: mediatek: Fix trigger type setting follow for
 unexpected interrupt

On Mon, Jan 25, 2021 at 5:18 AM Hailong Fan <hailong.fan@...iatek.com> wrote:

> When flipping the polarity will be generated interrupt under certain
> circumstances, but GPIO external signal has not changed.
> Then, mask the interrupt before polarity setting, and clear the
> unexpected interrupt after trigger type setting completed.
>
> Remove mtk_eint_flip_edge: because mtk_eint_unmask already calls it.
>
> Signed-off-by: Hailong Fan <hailong.fan@...iatek.com>
> Reviewed-by: Nicolas Boichat <drinkcat@...omium.org>

Took out v2 and applied this v3 instead.
(No idea what the difference is, you don't say.)

Yours,
Linus Walleij