linux-kernel - Re: [PATCH V3] pinctrl: mediatek: Fix trigger type setting follow for unexpected interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Jan 2021 09:22:35 +0800
From:   mtk15103 <hailong.fan@...iatek.com>
To:     Linus Walleij <linus.walleij@...aro.org>
CC:     Sean Wang <sean.wang@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        <youlin.pei@...iatek.com>, Nicolas Boichat <drinkcat@...omium.org>,
        <srv_heupstream@...iatek.com>, <chentsung@...omium.org>,
        <gtk_pangao@...iatek.com>, Hanks Chen <hanks.chen@...iatek.com>,
        <yong.wu@...iatek.com>
Subject: Re: [PATCH V3] pinctrl: mediatek: Fix trigger type setting follow
 for unexpected interrupt

On Mon, 2021-01-25 at 14:11 +0100, Linus Walleij wrote:
> On Mon, Jan 25, 2021 at 5:18 AM Hailong Fan <hailong.fan@...iatek.com> wrote:
> 
> > When flipping the polarity will be generated interrupt under certain
> > circumstances, but GPIO external signal has not changed.
> > Then, mask the interrupt before polarity setting, and clear the
> > unexpected interrupt after trigger type setting completed.
> >
> > Remove mtk_eint_flip_edge: because mtk_eint_unmask already calls it.
> >
> > Signed-off-by: Hailong Fan <hailong.fan@...iatek.com>
> > Reviewed-by: Nicolas Boichat <drinkcat@...omium.org>
> 
> Took out v2 and applied this v3 instead.
> (No idea what the difference is, you don't say.)
V3 only add commit message "Remove mtk_eint_flip_edge: because mtk_eint_unmask already calls it."
Compared to V2, the patch has not changed.
Thanks.

> Yours,
> Linus Walleij