linux-kernel - Re: [PATCH dwc-next v2 2/2] PCI: dwc: al: Remove useless dw_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9df69aa9373451f6ccb8884f72eda2623343168.camel@amazon.com>
Date:   Mon, 25 Jan 2021 20:57:42 +0000
From:   "Chocron, Jonathan" <jonnyc@...zon.com>
To:     "robh@...nel.org" <robh@...nel.org>,
        "jingoohan1@...il.com" <jingoohan1@...il.com>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "Jisheng.Zhang@...aptics.com" <Jisheng.Zhang@...aptics.com>,
        "gustavo.pimentel@...opsys.com" <gustavo.pimentel@...opsys.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH dwc-next v2 2/2] PCI: dwc: al: Remove useless dw_pcie_ops

On Fri, 2020-11-20 at 19:17 +0800, Jisheng Zhang wrote:
> CAUTION: This email originated from outside of the organization. Do
> not click links or open attachments unless you can confirm the sender
> and know the content is safe.
> 
> 
> 
> We have removed the dw_pcie_ops always exists assumption in dwc
> core driver, we can remove the useless dw_pcie_ops now.
> 
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@...aptics.com>
> ---
>  drivers/pci/controller/dwc/pcie-al.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-al.c
> b/drivers/pci/controller/dwc/pcie-al.c
> index 7ac8a37d9ce0..36977c48a7ae 100644
> --- a/drivers/pci/controller/dwc/pcie-al.c
> +++ b/drivers/pci/controller/dwc/pcie-al.c
> @@ -322,9 +322,6 @@ static const struct dw_pcie_host_ops
> al_pcie_host_ops = {
>         .host_init = al_pcie_host_init,
>  };
> 
> -static const struct dw_pcie_ops dw_pcie_ops = {
> -};
> -
>  static int al_pcie_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> @@ -342,7 +339,6 @@ static int al_pcie_probe(struct platform_device
> *pdev)
>                 return -ENOMEM;
> 
>         pci->dev = dev;
> -       pci->ops = &dw_pcie_ops;
>         pci->pp.ops = &al_pcie_host_ops;
> 
>         al_pcie->pci = pci;
> --
> 2.29.2
> 

Acked-by: Jonathan Chocron <jonnyc@...zon.com>


Thanks,
   Jonathan