linux-kernel - [PATCH] [net-next] ipa: add remoteproc dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20210125113557.2388311-1-arnd@kernel.org>
Date:   Mon, 25 Jan 2021 12:35:50 +0100
From:   Arnd Bergmann <arnd@...nel.org>
To:     Alex Elder <elder@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] [net-next] ipa: add remoteproc dependency

From: Arnd Bergmann <arnd@...db.de>

Compile-testing without CONFIG_REMOTEPROC results in a build failure:

>>> referenced by ipa_main.c
>>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
ld.lld: error: undefined symbol: rproc_put
>>> referenced by ipa_main.c
>>>               net/ipa/ipa_main.o:(ipa_probe) in archive drivers/built-in.a
>>> referenced by ipa_main.c
>>>               net/ipa/ipa_main.o:(ipa_remove) in archive drivers/built-in.a

Add a new dependency to avoid this.

Fixes: 38a4066f593c ("net: ipa: support COMPILE_TEST")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/net/ipa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ipa/Kconfig b/drivers/net/ipa/Kconfig
index b68f1289b89e..aa1c0ae3cf01 100644
--- a/drivers/net/ipa/Kconfig
+++ b/drivers/net/ipa/Kconfig
@@ -3,6 +3,7 @@ config QCOM_IPA
 	depends on 64BIT && NET && QCOM_SMEM
 	depends on ARCH_QCOM || COMPILE_TEST
 	depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
+	depends on REMOTEPROC
 	select QCOM_MDT_LOADER if ARCH_QCOM
 	select QCOM_QMI_HELPERS
 	help
-- 
2.29.2