linux-kernel - Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210126090525.4d085080@windsurf.home>
Date:   Tue, 26 Jan 2021 09:05:25 +0100
From:   Thomas Petazzoni <thomas.petazzoni@...tlin.com>
To:     Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "rppt@...nel.org" <rppt@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Grégory Clement <gregory.clement@...tlin.com>
Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with
 ioremap()

On Tue, 26 Jan 2021 01:48:23 +0000
Chris Packham <Chris.Packham@...iedtelesis.co.nz> wrote:

> Hi All,
> 
> On 12/11/20 9:02 pm, Thomas Petazzoni wrote:
> > On Thu, 12 Nov 2020 16:21:49 +1300
> > Chris Packham <chris.packham@...iedtelesis.co.nz> wrote:
> >  
> >> make coccicheck complains:
> >>
> >>    ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
> >>
> >> It took some staring but I don't think there is a problem because the
> >> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> >> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> >> are the same thing. But this is confusing for anyone reading the code
> >> and one less complaint from coccicheck would be nice so lets fix it.
> >>
> >> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>  
> > Acked-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com>  
> 
> Just going through some old branches. This doesn't seem to have been 
> picked up. Have I missed a maintainer?

+Gregory Clement in Cc. Greg, the original patch from Chris is touching
drivers/bus/mvebu-mbus.c, so I think you should be taking that patch.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com