linux-kernel - Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c0fd747-3ea1-2aa1-0c05-12ae4477a860@alliedtelesis.co.nz>
Date:   Tue, 26 Jan 2021 01:48:23 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "rppt@...nel.org" <rppt@...nel.org>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "jason@...edaemon.net" <jason@...edaemon.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with ioremap()

Hi All,

On 12/11/20 9:02 pm, Thomas Petazzoni wrote:
> On Thu, 12 Nov 2020 16:21:49 +1300
> Chris Packham <chris.packham@...iedtelesis.co.nz> wrote:
>
>> make coccicheck complains:
>>
>>    ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
>>
>> It took some staring but I don't think there is a problem because the
>> file global `mbus_state` is passed mvebu_mbus_common_init() as the
>> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
>> are the same thing. But this is confusing for anyone reading the code
>> and one less complaint from coccicheck would be nice so lets fix it.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@...tlin.com>

Just going through some old branches. This doesn't seem to have been 
picked up. Have I missed a maintainer?