linux-kernel - Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2221632.MzOyzyC30C@diego>
Date:   Tue, 26 Jan 2021 09:37:49 +0100
From:   Heiko Stübner <heiko@...ech.de>
To:     Johan Jonker <jbx6244@...il.com>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     robh+dt@...nel.org, wim@...ux-watchdog.org, jamie@...ieiles.com,
        linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH 1/8] dt-binding: watchdog: add more Rockchip compatibles to snps,dw-wdt.yaml

Hi Guenter,

Am Dienstag, 26. Januar 2021, 05:55:59 CET schrieb Guenter Roeck:
> On 1/25/21 3:40 PM, Heiko Stuebner wrote:
> > Am Samstag, 23. Januar 2021, 18:34:01 CET schrieb Guenter Roeck:
> >> On Fri, Dec 18, 2020 at 01:05:27PM +0100, Johan Jonker wrote:
> >>> The watchdog compatible strings are suppose to be SoC orientated.
> >>> In the more recently added Rockchip SoC dtsi files only
> >>> the fallback string "snps,dw-wdt" is used, so add the following
> >>> compatible strings:
> >>>
> >>> "rockchip,px30-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3228-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3308-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3328-wdt", "snps,dw-wdt"
> >>> "rockchip,rk3399-wdt", "snps,dw-wdt"
> >>> "rockchip,rv1108-wdt", "snps,dw-wdt"
> >>>
> >>> make ARCH=arm dtbs_check
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>>
> >>> make ARCH=arm64 dtbs_check
> >>> DT_SCHEMA_FILES=Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>>
> >>> Signed-off-by: Johan Jonker <jbx6244@...il.com>
> >>> Acked-by: Rob Herring <robh@...nel.org>
> >>> Reviewed-by: Heiko Stuebner <heiko@...ech.de>
> >>
> >> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> > 
> > just to clarify, do you expect me to pick up the dt-binding patch
> > with the devicetree patches or do you want to take this individual
> > patch through the watchdog tree instead?
> > 
> 
> You'd have to ask Wim since he takes care of actually sending pull requests.
> But didn't you say earlier that you wanted to apply the rest of the series
> after this one is applied through the watchdog tree ?

Yep that was my intent, though somehow I mistook you as also being
a watchdog maintainer, hence the confusion.

So I'll wait for Wim to apply this patch and then I'll take the rest of
the series.

Thanks
Heiko


> >>> ---
> >>>  Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml | 6 ++++++
> >>>  1 file changed, 6 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> index f7ee9229c..b58596b18 100644
> >>> --- a/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> +++ b/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml
> >>> @@ -18,10 +18,16 @@ properties:
> >>>        - const: snps,dw-wdt
> >>>        - items:
> >>>            - enum:
> >>> +              - rockchip,px30-wdt
> >>>                - rockchip,rk3066-wdt
> >>>                - rockchip,rk3188-wdt
> >>> +              - rockchip,rk3228-wdt
> >>>                - rockchip,rk3288-wdt
> >>> +              - rockchip,rk3308-wdt
> >>> +              - rockchip,rk3328-wdt
> >>>                - rockchip,rk3368-wdt
> >>> +              - rockchip,rk3399-wdt
> >>> +              - rockchip,rv1108-wdt
> >>>            - const: snps,dw-wdt
> >>>  
> >>>    reg:
> >>
> > 
> > 
> > 
> > 
> 
>