linux-kernel - Re: [PATCH v2 0/6] Stop NULLifying match pointer in of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+voSRnHEEkUZSasdKGrXiBs3yCmzHp6Ua4WNuAgnh4AQ@mail.gmail.com>
Date:   Tue, 26 Jan 2021 12:21:04 -0600
From:   Rob Herring <robh@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org,
        Alexandre Torgue <alexandre.torgue@...com>,
        Arnd Bergmann <arnd@...db.de>,
        "David S. Miller" <davem@...emloft.net>,
        Frank Rowand <frowand.list@...il.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Grygorii Strashko <grygorii.strashko@...com>,
        Guenter Roeck <linux@...ck-us.net>,
        Jacopo Mondi <jacopo@...ndi.org>,
        Jean Delvare <jdelvare@...e.com>, Jiri Slaby <jslaby@...e.com>,
        Linux HWMON List <linux-hwmon@...r.kernel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        linux-omap <linux-omap@...r.kernel.org>,
        "open list:MEDIA DRIVERS FOR RENESAS - FCP" 
        <linux-renesas-soc@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>,
        Linux USB List <linux-usb@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Richard Leitner <richard.leitner@...data.com>
Subject: Re: [PATCH v2 0/6] Stop NULLifying match pointer in of_match_device()

On Fri, Jan 22, 2021 at 9:44 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> (This is a continuation of this series[1] per Rob's request. I've picked
> up the acks, etc. with b4 and compile tested the patches along with an
> arm64 allmodconfig build. Presumably Rob will pick these up directly.)
>
> of_match_device() uses of_match_ptr() to make the match table argument
> NULL via the pre-processor when CONFIG_OF=n. This makes life harder for
> compilers who think that match tables are never used and warn about
> unused variables when CONFIG_OF=n. This series changes various callers
> to use of_device_get_match_data() instead, which doesn't have this
> problem, and removes the of_match_ptr() usage from of_match_device() so
> that the compiler can stop complaining about unused variables. It will
> do dead code elimination instead and remove the match table if it isn't
> actually used.
>
> [1] https://lore.kernel.org/r/20191004214334.149976-1-swboyd@chromium.org
>
> Cc: Alexandre Torgue <alexandre.torgue@...com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Frank Rowand <frowand.list@...il.com>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Grygorii Strashko <grygorii.strashko@...com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Jacopo Mondi <jacopo@...ndi.org>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Jiri Slaby <jslaby@...e.com>
> Cc: <linux-hwmon@...r.kernel.org>
> Cc: <linux-kernel@...r.kernel.org>,
> Cc: <linux-media@...r.kernel.org>
> Cc: <linux-omap@...r.kernel.org>
> Cc: <linux-renesas-soc@...r.kernel.org>
> Cc: <linux-serial@...r.kernel.org>
> Cc: <linux-usb@...r.kernel.org>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: Richard Leitner <richard.leitner@...data.com>
> Cc: Rob Herring <robh+dt@...nel.org>
>
> Stephen Boyd (6):
>   media: renesas-ceu: Use of_device_get_match_data()
>   drivers: net: davinci_mdio: Use of_device_get_match_data()
>   serial: stm32: Use of_device_get_match_data()
>   usb: usb251xb: Use of_device_get_match_data()
>   hwmon: (lm70) Avoid undefined reference to match table
>   of/device: Don't NULLify match table in of_match_device() with
>     CONFIG_OF=n
>
>  drivers/hwmon/lm70.c                   |  2 +-
>  drivers/media/platform/renesas-ceu.c   |  2 +-
>  drivers/net/ethernet/ti/davinci_mdio.c | 12 ++---
>  drivers/tty/serial/stm32-usart.c       | 71 ++++++++++++--------------
>  drivers/tty/serial/stm32-usart.h       |  2 +-
>  drivers/usb/misc/usb251xb.c            | 12 ++---
>  include/linux/of_device.h              |  4 +-
>  7 files changed, 47 insertions(+), 58 deletions(-)

Series applied.


Rob