linux-kernel - Re: [PATCH v2 5/6] hwmon: (lm70) Avoid undefined reference to match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqJbdfhqNF4xgues0Rm7KS8_8Xq2767q7DcdyeQ_Vqb58Q@mail.gmail.com>
Date:   Tue, 26 Jan 2021 12:30:58 -0600
From:   Rob Herring <robh@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        devicetree@...r.kernel.org, Guenter Roeck <linux@...ck-us.net>,
        Arnd Bergmann <arnd@...db.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jean Delvare <jdelvare@...e.com>,
        Frank Rowand <frowand.list@...il.com>,
        Linux HWMON List <linux-hwmon@...r.kernel.org>
Subject: Re: [PATCH v2 5/6] hwmon: (lm70) Avoid undefined reference to match table

On Fri, Jan 22, 2021 at 9:44 PM Stephen Boyd <swboyd@...omium.org> wrote:
>
> We're going to remove of_match_ptr() from the definition of
> of_match_device() when CONFIG_OF=n. This way we can always be certain
> that of_match_device() acts the same when CONFIG_OF is set and when it
> isn't. Add of_match_ptr() here so that this doesn't break when that
> change is made to the of_match_device() API.
>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> Acked-by: Guenter Roeck <linux@...ck-us.net>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Jean Delvare <jdelvare@...e.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Frank Rowand <frowand.list@...il.com>
> Cc: <linux-hwmon@...r.kernel.org>
> ---
>
> Please ack so Rob can apply.
>
>  drivers/hwmon/lm70.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
> index ae2b84263a44..e3153ae80634 100644
> --- a/drivers/hwmon/lm70.c
> +++ b/drivers/hwmon/lm70.c
> @@ -178,7 +178,7 @@ static int lm70_probe(struct spi_device *spi)
>         struct lm70 *p_lm70;
>         int chip;
>
> -       of_match = of_match_device(lm70_of_ids, &spi->dev);
> +       of_match = of_match_device(of_match_ptr(lm70_of_ids), &spi->dev);
>         if (of_match)
>                 chip = (int)(uintptr_t)of_match->data;

Why can't this do:

if (spi->dev.of_node)
    chip = (int)(uintptr_t)of_device_get_match_data();
else {

>         else {
> --
> https://chromeos.dev
>