linux-kernel - [PATCH] scsi: ufs: fix: NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1611737384-49321-1-git-send-email-abaci-bugfix@linux.alibaba.com>
Date:   Wed, 27 Jan 2021 16:49:44 +0800
From:   Abaci Team <abaci-bugfix@...ux.alibaba.com>
To:     jejb@...ux.ibm.com
Cc:     martin.petersen@...cle.com, alim.akhtar@...sung.com,
        avri.altman@....com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Abaci Team <abaci-bugfix@...ux.alibaba.com>
Subject: [PATCH] scsi: ufs: fix: NULL pointer dereference

Fix below warnings reported by coccicheck:
./drivers/scsi/ufs/ufshcd.c:8990:11-17: ERROR: hba is NULL but
dereferenced.

Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
Suggested-by: Yang Li <oswb@...ux.alibaba.com>
Signed-off-by: Abaci Team <abaci-bugfix@...ux.alibaba.com>
---
 drivers/scsi/ufs/ufshcd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fb32d12..9319251 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -8990,7 +8990,6 @@ int ufshcd_system_resume(struct ufs_hba *hba)
 	ktime_t start = ktime_get();
 
 	if (!hba) {
-		up(&hba->eh_sem);
 		return -EINVAL;
 	}
 
-- 
1.8.3.1