linux-kernel - RE: [PATCH] scsi: ufs: fix: NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR04MB65753A28501B1AE8CB893102FCBB9@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Wed, 27 Jan 2021 08:59:40 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     Abaci Team <abaci-bugfix@...ux.alibaba.com>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>
CC:     "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "alim.akhtar@...sung.com" <alim.akhtar@...sung.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] scsi: ufs: fix: NULL pointer dereference

> 
> Fix below warnings reported by coccicheck:
> ./drivers/scsi/ufs/ufshcd.c:8990:11-17: ERROR: hba is NULL but
> dereferenced.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Suggested-by: Yang Li <oswb@...ux.alibaba.com>
> Signed-off-by: Abaci Team <abaci-bugfix@...ux.alibaba.com>
This was already fix in commit fb7afe24ba1b (scsi: ufs: Fix a possible NULL pointer issue)

> ---
>  drivers/scsi/ufs/ufshcd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index fb32d12..9319251 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8990,7 +8990,6 @@ int ufshcd_system_resume(struct ufs_hba *hba)
>         ktime_t start = ktime_get();
> 
>         if (!hba) {
> -               up(&hba->eh_sem);
>                 return -EINVAL;
>         }
> 
> --
> 1.8.3.1